change api to dynamically check for breaking change #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename machine to node in api According to juanfont/headscale#1553 * more fixes
* added a new device registration form * removed unused variables * remove old register html * bind new device key from url * remove redirect * clear nodekey query string param after successuful addition * expand bool flipping * added documention on nodekey * remove null check * tweak wording
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests checks to see if the api routes for machine have been renamed to node and changes accordingly. Note that this introduces two API calls per device related request instead of one. Due to this, the recommendation is to remove this fix when the old version is deprecated.