Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test changes in this project today, you have to do the following:
dev
ordev2
branchlightgbm/vsts-agent:ubuntu-14.04-dev
)dev
intomaster
hereThis PR proposes a different pattern that I think will make testing easier. It introduces a GitHub Actions
workflow_dispatch
event to trigger the workflow that builds and pushes images. That way, anyone who can create branches here (which should only be LightGBM maintainers) can just push changes to that branch and click a button to build new images. Those new images will then be tagged with that branch name, e.g.lightgbm/vsts-agent:ubuntu-14.04-some-branch
.This also proposes updating all third-party actions used here to their latest versions.
Why I'm confident this will work
We do the same thing for the link-checker job over in LightGBM.
https://github.com/microsoft/LightGBM/blob/8ed371cee49cf86740b25dd9a4b985a75c9f2dba/.github/workflows/linkchecker.yml#L4-L5
Notes for Reviewers
@guolinke could you make me an admin in this repo and add me to the
lightgbm
DockerHub organization (https://hub.docker.com/u/lightgbm)?So that I can modify permissions and delete temporary testing images pushed to DockerHub.