Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra data is a field in Django that will disappear sooner or later, … #941

Merged
merged 1 commit into from
Aug 20, 2017
Merged

Conversation

Issen007
Copy link

…so this field is not required anymore when creating a new Statement/responds manually in Django Admin.

…so this field is not required anymore when creating a new Statement/responds manually in Django Admin.
@Issen007
Copy link
Author

@gunthercox

@gunthercox
Copy link
Owner

Does this fix anything or is this just an ascetic change?

@Issen007
Copy link
Author

@gunthercox this is only a smaller change, because in existing version if I try to create a Statement or Responds manually today, then is the Extra Data field a required field that you must fill out.

With this smaller change I have change that column to no mandatory field so you can still create a statement or responds manually without to fill out the Extra data field.

Copy link
Owner

@gunthercox gunthercox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
I'll add a migration file after this gets merged in.

@gunthercox gunthercox merged commit ca2a187 into gunthercox:master Aug 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants