-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sqlite pragma settings to sql_storage.py - change distinct to aggregate in mongodb.py #916
Merged
Merged
Changes from 2 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
af76b8c
add sqlite pragma settings
lesleslie 99b14ed
change default_session.id to default_conversation_id
lesleslie 957a970
switch statement for response line 118
lesleslie 25a2f1a
work
lesleslie 29cd3fe
bug fix
lesleslie 9c202a8
undo statement to response
lesleslie 16beccd
increase sort buffer to 42M
lesleslie a86df43
converation --> conversation
lesleslie 17f0a1b
add mock to requirements.txt - needed for tests
lesleslie 01a43cc
add package requirements for testing, bump pymongo version to 3.4
lesleslie 73295bc
remove those last requirements - found dev-requirements.txt
lesleslie f844bbf
and again for coverage
lesleslie a58f3e0
self.client.admin.command({'setFeatureCompatibilityVersion': '3.4'})
lesleslie bfbadc4
self.client.admin.command({'setFeatureCompatibilityVersion': '3.2'})
lesleslie 5066b2c
back out few commits - see travis errors again
lesleslie 0ba10a6
bump pymongo to 3.4
lesleslie 0346efd
reset pymongo version to 3.3, import OperationFailure
lesleslie 11272e9
DEFAULT_SESSION_ID --> DEFAULT_CONVERSATION_ID
lesleslie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,7 +16,7 @@ | |
|
||
bot.train("chatterbot.corpus.english") | ||
|
||
DEFAULT_SESSION_ID = bot.default_session.id | ||
DEFAULT_SESSION_ID = bot.default_conversation_id | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this could also rephrase to DEFAULT_CONVERSATION_ID There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done. |
||
|
||
|
||
def get_feedback(): | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could also rephrase to DEFAULT_CONVERSATION_ID
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.