Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to SQL adapter as default database adapter for ChatterBot #796

Merged
merged 3 commits into from
Jun 24, 2017

Conversation

gunthercox
Copy link
Owner

@gunthercox gunthercox commented Jun 17, 2017

This pull request reveals what tests fail after setting the SQL storage adapter as the default for ChatterBot. These failures will need to be corrected before the adapter can be used in production.

Updates:


======================================================================
FAIL: Test that an additional data attribute can be added to the statement
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/gcox/GitHub/ChatterBot/tests/logic_adapter_tests/test_data_cache.py", line 46, in test_additional_attributes_saved
    self.assertIn('pos_tags', data['extra_data'])
AssertionError: 'pos_tags' not found in {}
-------------------- >> begin captured logging << --------------------
chatterbot.adapters: INFO: Recieved input statement: Hello
chatterbot.adapters: INFO: "Hello" is a known statement
--------------------- >> end captured logging << ---------------------

======================================================================
FAIL: If an input statement has data contained in the
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/gcox/GitHub/ChatterBot/tests/test_chatbot.py", line 106, in test_response_extra_data
    self.assertIn('test', saved_statement.extra_data)
AssertionError: 'test' not found in {}
-------------------- >> begin captured logging << --------------------
chatterbot.adapters: INFO: Recieved input statement: Hello
chatterbot.adapters: INFO: "Hello" is not a known statement
chatterbot.adapters: INFO: Not processing the statement using BestMatch
chatterbot.adapters: INFO: NoKnowledgeAdapter selected "Hello" as a response with a confidence of 1
--------------------- >> end captured logging << ---------------------

----------------------------------------------------------------------
Ran 341 tests in 20.285s

FAILED (SKIP=35, failures=2)

@gunthercox gunthercox force-pushed the sql-defaults branch 3 times, most recently from 4f7b83f to 86ba7e9 Compare June 24, 2017 13:57
@gunthercox gunthercox changed the title Pull request to reveal failing tests for SQL storage adapter Switch to SQL adapter as default database adapter for ChatterBot Jun 24, 2017
@gunthercox gunthercox merged commit 5e18851 into master Jun 24, 2017
@gunthercox gunthercox deleted the sql-defaults branch June 24, 2017 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant