(Bugfix) Fixes only and exclude nested props #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regiscamimura
force-pushed
the
bug/only-and-exclude-cleanup
branch
3 times, most recently
from
1ec0a63
to
c689975
Compare
regiscamimura
force-pushed
the
bug/only-and-exclude-cleanup
branch
from
c689975
to
f3a1121
Compare
regiscamimura
force-pushed
the
bug/only-and-exclude-cleanup
branch
from
f3a1121
to
7840552
Compare
jciskey
approved these changes
Aug 2, 2023
tests/test_views.py
Outdated
| response = client.get(f"/profiles/trimmed/{profile.pk}/") | ||
| result = response.json() | ||
| assert response.status_code == 200, result | ||
| assert "username" not in result |
There was a problem hiding this comment.
Not a blocking change, but I'd argue that since this is testing the only keyword, we should be checking to ensure that the only key in the response is the id key, not just that a particular other key isn't present.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Marshmallow pass
onlyandexcludeprops through a normalizer that removes nested properties (defined in API and using the dot notation, f.e.profile.user.id). When we call the serializer,onlyandexcludeare already changed, so I added araw_onlyandraw_excludeto pass forward and Marshmallow can do its magic from there.What Worf gif best describes this PR or how it makes you feel?
Checklist