Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHC_FILESYSTEM_WITH_INSTALL always on #160

Closed
DioEgizio opened this issue Oct 14, 2022 · 2 comments
Closed

GHC_FILESYSTEM_WITH_INSTALL always on #160

DioEgizio opened this issue Oct 14, 2022 · 2 comments
Labels
available on master Fix is done on master branch, issue closed on next release bug Something isn't working

Comments

@DioEgizio
Copy link

https://github.com/gulrak/filesystem#git-submodule-and-cmake says it should be off when used as a submodule, but it's actually always on :p

filesystem/CMakeLists.txt

Line 18 in cd6805e

option(GHC_FILESYSTEM_WITH_INSTALL "With install target" ON)

@DioEgizio DioEgizio mentioned this issue Oct 14, 2022
Merged
@gulrak
Copy link
Owner

gulrak commented Feb 17, 2023

I'll look into it.

gulrak added a commit that referenced this issue Mar 4, 2023
@gulrak
refs #160, only enable install target by default if not subproject as…
2a81c2c 
… documented
@gulrak gulrak added bug Something isn't working available on master Fix is done on master branch, issue closed on next release labels Mar 4, 2023
@gulrak
Copy link
Owner

gulrak commented Mar 5, 2023

Released with v1.5.14.

@gulrak gulrak closed this as completed Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
available on master Fix is done on master branch, issue closed on next release bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gulrak @DioEgizio