Correct File.clone() treatment of File.stats #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloning the stats object would remove its prototype, meaning it would lose methods normally available on fs.Stats instances, such as Stats.isDirectory() or Stats.isFile() This resulted in errors being thrown whenever a cloned file was piped through to a gulp.dest() stream when it expected the isDirectory() method.
|
@contra using the freshly published |
|
@hughsk the module needs tests and so does this PR |
|
@contra done, for both. |
yocontra
added a commit
that referenced
this pull request
Jan 11, 2014
Correct File.clone() treatment of File.stats
phated
pushed a commit
that referenced
this pull request
Sep 27, 2016
Correct File.clone() treatment of File.stats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloning the stats object would remove its prototype, meaning it would lose methods normally available on
fs.Statsinstances, such as
Stats.isDirectory()orStats.isFile()This was giving me errors when cloning vinyl instances and then piping them to
gulp.dest()streams, which do a directory check if thestatsproperty is present:This should fix the problem :)