Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace chalk #125

Closed
phated opened this issue Aug 19, 2017 · 2 comments
Closed

Replace chalk #125

phated opened this issue Aug 19, 2017 · 2 comments
Labels
help wanted
Milestone
2.0.0

Comments

@phated
Copy link
Member

phated commented Aug 19, 2017

I'm thinking we should replace chalk with individual ansi-* modules from @jonschlinkert: https://github.com/jonschlinkert?utf8=%E2%9C%93&tab=repositories&q=ansi&type=&language=
@timdeschryver timdeschryver mentioned this issue Aug 22, 2017
Closed
@yocontra
Copy link
Member

Why? Sounds like a ton of overhead in deps and increased code complexity.

@phated
Copy link
Member Author

phated commented Aug 23, 2017

Because chalk is overkill and we are removing sindre deps due to desupporting node 0.10

@phated phated closed this as completed in 1379433 Dec 13, 2017
@phated phated added this to the 2.0.0 milestone Dec 13, 2017
phated pushed a commit that referenced this issue Dec 21, 2017
@timdeschryver @phated
Breaking: Replace chalk with ansi-colors (closes #125)
7412027
phated pushed a commit that referenced this issue Dec 21, 2017
@timdeschryver @phated
Breaking: Replace chalk with ansi-colors (closes #125)
360671b
phated pushed a commit that referenced this issue Dec 21, 2017
@timdeschryver @phated
Breaking: Replace chalk with ansi-colors (closes #125)
a926d9e
phated pushed a commit that referenced this issue Dec 21, 2017
@timdeschryver @phated
Breaking: Replace chalk with ansi-colors (closes #125)
09bcc52
phated pushed a commit that referenced this issue Dec 21, 2017
@timdeschryver @phated
Breaking: Replace chalk with ansi-colors (closes #125)
9df91cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
2 participants
@yocontra @phated