Throw on invalid glob, clean up, 100% coverage, closes #34 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Shiny 100% 😺 |
| return false; | ||
| if (pattern instanceof RegExp) return true; | ||
| if (typeof pattern === 'string') return pattern[0] === '!'; | ||
| throw new Error('Invalid glob argument'); |
There was a problem hiding this comment.
should emit the glob index that was invalid. I think this validation belongs at the top of the main globs loop not in a sub-function
|
Thinking again, the |
- Better naming for negative matchers ( gulpjs#33 (comment) ) - Throw on invalid glob argument ( gulpjs#34 (comment) ) - Removed the `if (!Array.isArray(globs)) return gs.createStream(globs, [], opt);` because this optimization is already covered a couple lines below at `if (positives.length === 1) return streamFromPositive(positives[0]);`, and to not duplicate the validation code. Previously, passing a string with a negative glob did not throw a "Missing positive glob" error, now it does.
|
PTAL. |
|
Nice and clean now - thanks! |
yocontra
pushed a commit
that referenced
this pull request
Jan 2, 2015
Throw on invalid glob, clean up, 100% coverage, closes #34
phated
pushed a commit
that referenced
this pull request
Feb 16, 2017
Throw on invalid glob, clean up, 100% coverage, closes #34
phated
pushed a commit
that referenced
this pull request
Feb 16, 2017
Throw on invalid glob, clean up, 100% coverage, closes #34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if (!Array.isArray(globs)) return gs.createStream(globs, [], opt);because this optimization is already covered a couple lines below atif (positives.length === 1) return streamFromPositive(positives[0]);, and to not duplicate the validation code. Previously, passing a string with a negative glob did not throw a "Missing positive glob" error, now it does.