-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Minimatch class for improved perf #29
Comments
Before I send a PR to fix this, does glob-stream's |
@UltCombo We do support custom RegExps at the post-scan level https://github.com/wearefractal/glob-stream/blob/master/index.js#L104 I'd like to keep that if possible |
@contra Oh I see. But https://github.com/wearefractal/glob-stream/blob/master/index.js#L109 shouldn't be |
@UltCombo All RegExps are treated as negative since they are used to filter post-scan which means they cannot be positive. You can't give a regex to node-glob so there is no way it could be positive. There probably aren't tests if you can't find any, but there should be |
Oh I see, thanks for the explanation |
use Minimatch class to improve perf, fixes #29; fix RegExp handling
use Minimatch class to improve perf, fixes #29; fix RegExp handling
use Minimatch class to improve perf, fixes #29; fix RegExp handling
While node-glob doesn't implement the
ignore
option, it would be faster to handle handle globs with the Minimatch class (see sindresorhus/globby#6 (comment) and the comment below).The text was updated successfully, but these errors were encountered: