Breaking: Avoid returning 0, return 1 if millisecond resolution (fixes …

…#5)
gulpjs · Jun 11, 2016 · 0059b0b · 0059b0b
1 parent 14b6c36
commit 0059b0b
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 11 deletions.
diff --git a/README.md b/README.md
@@ -14,8 +14,8 @@ Split out for standalone use.
 var defaultResolution = require('default-resolution');
 
 defaultResolution();
-//-> 1000 in node 0.10
-//-> 0 in node 0.11+
+//-> 1000 (1 second) in node 0.10
+//-> 1 (millisecond) in node 0.11+
 
 // use a different value
 defaultResolution(12);

diff --git a/index.js b/index.js
@@ -3,13 +3,13 @@
 var nodeVersion = require('./node-version');
 
 function defaultResolution(customResolution) {
-  var resolution = parseInt(customResolution, 10) || 0;
+  var resolution = parseInt(customResolution, 10);
 
   if (resolution) {
     return resolution;
   }
 
-  return (nodeVersion.major === 0 && nodeVersion.minor <= 10) ? 1000 : 0;
+  return (nodeVersion.major === 0 && nodeVersion.minor <= 10) ? 1000 : 1;
 }
 
 defaultResolution.nodeVersion = nodeVersion;

diff --git a/test/default-resolution.js b/test/default-resolution.js
@@ -27,31 +27,31 @@ lab.describe('defaultResolution', function() {
     done();
   });
 
-  lab.it('should return default resolution to 1000 on node v0.10', function(done) {
+  lab.it('should return default resolution to 1000 (1 second) on node v0.10', function(done) {
     nodeVersion.major = 0;
     nodeVersion.minor = 10;
     code.expect(defaultResolution()).to.equal(1000);
     done();
   });
 
-  lab.it('should return default resolution to 0 on node v0.11', function(done) {
+  lab.it('should return default resolution to 1 (millisecond) on node v0.11', function(done) {
     nodeVersion.major = 0;
     nodeVersion.minor = 11;
-    code.expect(defaultResolution()).to.equal(0);
+    code.expect(defaultResolution()).to.equal(1);
     done();
   });
 
-  lab.it('should return default resolution to 0 on node v0.12', function(done) {
+  lab.it('should return default resolution to 1 (millisecond) on node v0.12', function(done) {
     nodeVersion.major = 0;
     nodeVersion.minor = 12;
-    code.expect(defaultResolution()).to.equal(0);
+    code.expect(defaultResolution()).to.equal(1);
     done();
   });
 
-  lab.it('should return default resolution to 0 on iojs v1.5', function(done) {
+  lab.it('should return default resolution to 1 (millisecond) on iojs v1.5', function(done) {
     nodeVersion.major = 1;
     nodeVersion.minor = 1;
-    code.expect(defaultResolution()).to.equal(0);
+    code.expect(defaultResolution()).to.equal(1);
     done();
   });