Add implementation. #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@coreyfarrell this is awesome! I don't have much time to look at this right now but I'll try to squeeze some time in to review and bring this in this upcoming week (might find a chance this weekend?). |
|
Thanks @coreyfarrell!!! Again, this is awesome. I'm going to make some small changes before I publish as 1.0.0 |
|
1.0.0 published at https://www.npmjs.com/package/@gulp-sourcemaps/sources-content This was great work - would you be interested in becoming a gulp-sourcemaps contributor? There was a lot of work planned to refactor the monolithic plugin into smaller ones like this but I don't have enough time in the day. |
|
Thanks for merging and publishing. Sure I use gulp-sourcemaps so I'll help as I can. |
|
Awesome, invite sent! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements, tests and documents this module. If you don't like the API decision I made I can change it so this module exports a
.loadand.remove, personally I think an off by default option for clearing the existing sourcesContent makes sense. I found myself here because I need tomapSourcesto paths that are valid from the web but do not exist on the filesystem, this causedgulpSourcemaps.writeto load sourcesContent with a bunch ofnullvalues. I've already verified that using this module beforemapSourcesproduces a correct/complete sourcemap without modifying gulp-sourcemap as long as theincludeContentoption doesn't conflict.Fixes #1, Fixes #2