Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind visibility after creation to prevent multiple calls #454

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

KBroichhausen
Copy link
Contributor

First create the elements and then create initial bind of visibility by calling _bindVisibility just for the root element.

If you have many nested objects, this is a lot faster because each PropertyGroup does not call _bindVisibility at creation. Previously, it was called for each one at creation but eventually it will get called anyways because root element is a PropertyGroup which calls _bindVisibility of childs (and therefore for child PropertyGroups).

@ebrehault ebrehault merged commit 8f2e5a6 into guillotinaweb:master Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants