make the dll_copy generated file a PRIVATE target_source #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file is creating an error when trying to install as explained here https://stackoverflow.com/questions/60736689/cmake-target-sources-and-install.
|
Thanks for the PR! Did you manage to test the fix? I'm not used to FindContent. Can you see a way to implement a test? Maybe inspired by the existing test that ensure ozz can be used as a sub/external project? Cheers, |
great, I didn't know you had tests for CMake cases, I should be able to add one for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for the excellent library! I tried to use it in my project with
FetchContentbut got an error when installing saying that thedll_copytarget source is inside the binary dir. By changing it toPRIVATEit seems to work, but I'm no CMake expert so maybe this solution has other effects, but I couldn't find any. I think it's better explained here.