Cleans application interface.

guillaumeblanc · May 20, 2024 · e409377 · e409377
1 parent 0c6f77b
commit e409377
Show file tree

Hide file tree

Showing 18 changed files with 8 additions and 63 deletions.
diff --git a/samples/additive/sample_additive.cc b/samples/additive/sample_additive.cc
@@ -232,8 +232,6 @@ class AdditiveBlendSampleApplication : public ozz::sample::Application {
     return true;
   }
 
-  virtual void OnDestroy() {}
-
   virtual bool OnGui(ozz::sample::ImGui* _im_gui) {
     char label[64];
 

diff --git a/samples/attach/sample_attach.cc b/samples/attach/sample_attach.cc
@@ -134,8 +134,6 @@ class AttachSampleApplication : public ozz::sample::Application {
     return true;
   }
 
-  virtual void OnDestroy() {}
-
   virtual bool OnGui(ozz::sample::ImGui* _im_gui) {
     // Exposes animation runtime playback controls.
     {

diff --git a/samples/baked/sample_baked.cc b/samples/baked/sample_baked.cc
@@ -110,8 +110,6 @@ class BakedSampleApplication : public ozz::sample::Application {
     return true;
   }
 
-  virtual void OnDestroy() {}
-
   virtual bool OnDisplay(ozz::sample::Renderer* _renderer) {
     // Render a 1m size boxes for every joint. The scale of each box come from
     // the animation.

diff --git a/samples/blend/sample_blend.cc b/samples/blend/sample_blend.cc
@@ -210,8 +210,6 @@ class BlendSampleApplication : public ozz::sample::Application {
     return true;
   }
 
-  virtual void OnDestroy() {}
-
   virtual bool OnGui(ozz::sample::ImGui* _im_gui) {
     // Exposes blending parameters.
     {

diff --git a/samples/foot_ik/sample_foot_ik.cc b/samples/foot_ik/sample_foot_ik.cc
@@ -589,8 +589,6 @@ class FootIKSampleApplication : public ozz::sample::Application {
     return found == 3;
   }
 
-  virtual void OnDestroy() {}
-
   virtual bool OnGui(ozz::sample::ImGui* _im_gui) {
     char label[32];
 

diff --git a/samples/framework/application.cc b/samples/framework/application.cc
@@ -670,44 +670,23 @@ bool Application::OnInitialize() { return true; }
 
 void Application::OnDestroy() {}
 
-bool Application::OnUpdate(float _dt, float _time) {
-  (void)_dt;
-  (void)_time;
-  return true;
-}
+bool Application::OnUpdate(float, float) { return true; }
 
-bool Application::OnGui(ImGui* _im_gui) {
-  (void)_im_gui;
-  return true;
-}
+bool Application::OnGui(ImGui*) { return true; }
 
-bool Application::OnFloatingGui(ImGui* _im_gui) {
-  (void)_im_gui;
-  return true;
-}
+bool Application::OnFloatingGui(ImGui*) { return true; }
 
-bool Application::OnDisplay(Renderer* _renderer) {
-  (void)_renderer;
-  return true;
-}
+bool Application::OnDisplay(Renderer*) { return true; }
 
-bool Application::GetCameraInitialSetup(math::Float3* _center,
-                                        math::Float2* _angles,
-                                        float* _distance) const {
-  (void)_center;
-  (void)_angles;
-  (void)_distance;
+bool Application::GetCameraInitialSetup(math::Float3*, math::Float2*,
+                                        float*) const {
   return false;
 }
 
 // Default implementation doesn't override camera location.
-bool Application::GetCameraOverride(math::Float4x4* _transform) const {
-  (void)_transform;
-  assert(_transform);
-  return false;
-}
+bool Application::GetCameraOverride(math::Float4x4*) const { return false; }
 
-void Application::GetSceneBounds(math::Box* _bound) const { (void)_bound; }
+void Application::GetSceneBounds(math::Box*) const {}
 
 math::Float2 Application::WorldToScreen(const math::Float3& _world) const {
   const math::SimdFloat4 ndc =

diff --git a/samples/look_at/sample_look_at.cc b/samples/look_at/sample_look_at.cc
@@ -362,8 +362,6 @@ class LookAtSampleApplication : public ozz::sample::Application {
     return count == i;
   }
 
-  virtual void OnDestroy() {}
-
   virtual bool OnGui(ozz::sample::ImGui* _im_gui) {
     char label[64];
 

diff --git a/samples/millipede/sample_millipede.cc b/samples/millipede/sample_millipede.cc
@@ -143,8 +143,6 @@ class MillipedeSampleApplication : public ozz::sample::Application {
 
   virtual bool OnInitialize() { return Build(); }
 
-  virtual void OnDestroy() {}
-
   virtual bool OnGui(ozz::sample::ImGui* _im_gui) {
     // Rebuilds all if the number of joints has changed.
     int joints = skeleton_->num_joints();

diff --git a/samples/motion_blend/sample_motion_blend.cc b/samples/motion_blend/sample_motion_blend.cc
@@ -310,8 +310,6 @@ class MotionBlendSampleApplication : public ozz::sample::Application {
     return true;
   }
 
-  virtual void OnDestroy() {}
-
   virtual bool OnGui(ozz::sample::ImGui* _im_gui) {
     char label[64];
 

diff --git a/samples/motion_extraction/sample_motion_extraction.cc b/samples/motion_extraction/sample_motion_extraction.cc
@@ -266,8 +266,6 @@ class MotionExtractionSampleApplication : public ozz::sample::Application {
     return true;
   }
 
-  virtual void OnDestroy() {}
-
   virtual bool OnGui(ozz::sample::ImGui* _im_gui) {
     // Exposes animation runtime playback controls.
     {

diff --git a/samples/motion_playback/sample_motion_playback.cc b/samples/motion_playback/sample_motion_playback.cc
@@ -184,8 +184,6 @@ class MotionPlaybackSampleApplication : public ozz::sample::Application {
     return true;
   }
 
-  virtual void OnDestroy() {}
-
   virtual bool OnGui(ozz::sample::ImGui* _im_gui) {
     char label[64];
     // Exposes animation runtime playback controls.

diff --git a/samples/multithread/sample_multithread.cc b/samples/multithread/sample_multithread.cc
@@ -272,8 +272,6 @@ class MultithreadSampleApplication : public ozz::sample::Application {
     return true;
   }
 
-  virtual void OnDestroy() {}
-
   virtual bool OnGui(ozz::sample::ImGui* _im_gui) {
     // Exposes number of characters.
     {

diff --git a/samples/optimize/sample_optimize.cc b/samples/optimize/sample_optimize.cc
@@ -434,8 +434,6 @@ class OptimizeSampleApplication : public ozz::sample::Application {
     return true;
   }
 
-  virtual void OnDestroy() {}
-
   bool BuildAnimations() {
     // Instantiate an animation builder.
     ozz::animation::offline::AnimationBuilder animation_builder;

diff --git a/samples/partial_blend/sample_partial_blend.cc b/samples/partial_blend/sample_partial_blend.cc
@@ -231,8 +231,6 @@ class PartialBlendSampleApplication : public ozz::sample::Application {
     ozz::animation::IterateJointsDF(skeleton_, upper_it, upper_body_root_);
   }
 
-  virtual void OnDestroy() {}
-
   virtual bool OnGui(ozz::sample::ImGui* _im_gui) {
     // Exposes blending parameters.
     {

diff --git a/samples/playback/sample_playback.cc b/samples/playback/sample_playback.cc
@@ -111,8 +111,6 @@ class PlaybackSampleApplication : public ozz::sample::Application {
     return true;
   }
 
-  virtual void OnDestroy() {}
-
   virtual bool OnGui(ozz::sample::ImGui* _im_gui) {
     // Exposes animation runtime playback controls.
     {

diff --git a/samples/skinning/sample_skinning.cc b/samples/skinning/sample_skinning.cc
@@ -176,8 +176,6 @@ class SkinningSampleApplication : public ozz::sample::Application {
     return true;
   }
 
-  virtual void OnDestroy() {}
-
   virtual bool OnGui(ozz::sample::ImGui* _im_gui) {
     // Exposes model informations.
     {

diff --git a/samples/two_bone_ik/sample_two_bone_ik.cc b/samples/two_bone_ik/sample_two_bone_ik.cc
@@ -236,8 +236,6 @@ class TwoBoneIKSampleApplication : public ozz::sample::Application {
     return true;
   }
 
-  virtual void OnDestroy() {}
-
   virtual bool OnGui(ozz::sample::ImGui* _im_gui) {
     char label[32];
 

diff --git a/samples/user_channel/sample_user_channel.cc b/samples/user_channel/sample_user_channel.cc
@@ -282,8 +282,6 @@ class UserChannelSampleApplication : public ozz::sample::Application {
     return true;
   }
 
-  virtual void OnDestroy() {}
-
   virtual bool OnGui(ozz::sample::ImGui* _im_gui) {
     // Exposes sample specific parameters.
     {