Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

with nulldb updated, add AR7.2 tests #40

Merged
merged 1 commit into from
Nov 14, 2024
Merged

with nulldb updated, add AR7.2 tests #40

merged 1 commit into from
Nov 14, 2024

Conversation

ahaverbuch
Copy link
Contributor

@ahaverbuch ahaverbuch commented Nov 14, 2024 •
edited
Loading

  • with nulldb updated, add AR7.2 tests

@ahaverbuch ahaverbuch requested a review from a team as a code owner November 14, 2024 21:03
@ahaverbuch ahaverbuch changed the title with nulldb updated, add AR7.2 and AR8.0 tests with nulldb updated, add AR7.2 tests Nov 14, 2024
ahaverbuch
ahaverbuch commented Nov 14, 2024
View reviewed changes
spec/spec_helper.rb
@@ -11,7 +11,6 @@
require 'stator'

RSpec.configure do |config|
config.treat_symbols_as_metadata_keys_with_true_values = true
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was deprecated in all of our versions, so removing. it's true by default

@ahaverbuch ahaverbuch enabled auto-merge (squash) November 14, 2024 21:18
@ahaverbuch ahaverbuch merged commit 1da25e3 into main Nov 14, 2024
4 checks passed
@ahaverbuch ahaverbuch deleted the rails branch November 14, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fusion2004 fusion2004 fusion2004 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahaverbuch @fusion2004