Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create deploy.yml #9

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Create deploy.yml #9

merged 2 commits into from
Oct 16, 2024

Conversation

guibranco
Copy link
Owner

@guibranco guibranco commented Oct 16, 2024

User description

Closes #

📑 Description

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

☢️ Does this introduce a breaking change?

  • Yes
  • No

ℹ Additional Information


Description

  • Introduced a new deployment workflow to automate FTP uploads.
  • The workflow triggers on pushes to the main branch and can be manually dispatched.
  • Includes steps for setting up Node.js, installing dependencies, building the site, and uploading it via FTP.
  • Also creates a release with versioning based on GitVersion.

Changes walkthrough 📝

Relevant files
Enhancement
deploy.yml
Add FTP Deployment Workflow with Release Creation               

.github/workflows/deploy.yml

  • Added a new GitHub Actions workflow for deployment via FTP.
  • Configured steps for version determination, Node.js setup, and site
    build.
  • Implemented FTP upload for the built site and release creation.
  • +69/-0   

    💡 Penify usage:
    Comment /help on the PR to get a list of all available Penify tools and their descriptions

    @guibranco guibranco enabled auto-merge (squash) October 16, 2024 09:47
    @gstraccini gstraccini bot added the ☑️ auto-merge Automatic merging of pull requests (gstraccini-bot) label Oct 16, 2024
    @penify-dev penify-dev bot added the enhancement New feature or request label Oct 16, 2024
    @guibranco guibranco merged commit 1244788 into main Oct 16, 2024
    10 checks passed
    @guibranco guibranco deleted the guibranco-patch-1 branch October 16, 2024 09:48
    Copy link
    Contributor

    penify-dev bot commented Oct 16, 2024

    PR Review 🔍

    ⏱️ Estimated effort to review [1-5]

    2, because the workflow file is straightforward and primarily involves standard actions without complex logic.

    🧪 Relevant tests

    No

    ⚡ Possible issues

    No

    🔒 Security concerns

    Sensitive information exposure: The FTP credentials are being used as secrets, which is good practice. Ensure that the secrets are properly configured in the repository settings to avoid exposure.

    Copy link
    Contributor

    penify-dev bot commented Oct 16, 2024

    PR Code Suggestions ✨

    No code suggestions found for PR.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    ☑️ auto-merge Automatic merging of pull requests (gstraccini-bot) enhancement New feature or request Review effort [1-5]: 2
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant