Feature/ui size improvements #634
Conversation
…oesn't seem to minimize the imports properly. Saves 80kb
Codecov Report
@@ Coverage Diff @@
## develop #634 +/- ##
===========================================
+ Coverage 56.73% 57.60% +0.86%
===========================================
Files 115 116 +1
Lines 3874 3892 +18
===========================================
+ Hits 2198 2242 +44
+ Misses 1676 1650 -26
Continue to review full report at Codecov.
|
…owsers. Webpack size is now 2.39MiB
|
Down to 2.39MiB |
acepace
changed the title
Add font-display tag to ensure text is displayed while font is loaded
…tick it properly. :(
| "es2015", | ||
| "stage-0", | ||
| "react" | ||
| [ | ||
| "@babel/preset-env", | ||
| { | ||
| "useBuiltIns": "entry" | ||
| } | ||
| ], |
There was a problem hiding this comment.
Can you tell me more about this change? preset-env by default parses into es2015 and what did stage-0 do ?
There was a problem hiding this comment.
stage-0 and es2015 were what babelrc transpiled into. All modern browsers already support it so there's nothing to transpire.
babel/preset-env lets babel target using browserslist (see change in package.json), which I defined to all browsers in use (0.25% and up). So not es2015.
There was a problem hiding this comment.
Debug output shows that currently this means the following results
Using targets:
{
"chrome": "49",
"edge": "18",
"firefox": "73",
"ie": "11",
"ios": "12",
"opera": "66",
"safari": "12.1",
"samsung": "10.1"
}
|
@ShayNehmad the build fails because I added react validation to eslint. |
|
@VakarisZ the two PTH icons are 1100x1100. Think it's ok to resize them or just to reformat them as 8bit colors rather than 32b, like the rest of the icons? |
monkey/monkey_island/cc/ui/src/components/pages/ConfigurePage.js
Outdated
Show resolved
Hide resolved
What is this?
Improves on #633 by reducing size.
Develop = 3.4MiB
Lodash optimization = 3.35MiB
forteawesome optimization = 3.26MiB