Bootlaoder reliability #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #600 +/- ##
===========================================
+ Coverage 56.72% 56.83% +0.10%
===========================================
Files 112 115 +3
Lines 3820 3869 +49
===========================================
+ Hits 2167 2199 +32
- Misses 1653 1670 +17
Continue to review full report at Codecov.
|
ShayNehmad
reviewed
Apr 2, 2020
| @@ -17,7 +17,7 @@ def parse_bootloader_telem(telem: Dict) -> bool: | |||
| telem['os_version'] = "Unknown OS" | |||
|
|
|||
| telem_id = BootloaderService.get_mongo_id_for_bootloader_telem(telem) | |||
| mongo.db.bootloader_telems.update({'_id': telem_id}, telem, upsert=True) | |||
| mongo.db.bootloader_telems.update({'_id': telem_id}, {'$setOnInsert': telem}, upsert=True) | |||
There was a problem hiding this comment.
What do you think about logging if something already exists?
There was a problem hiding this comment.
Log would be redundant, because we expect this to happen 100% of the time
ShayNehmad
approved these changes
Apr 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pyinstaller seems to launch bootloader two times. The second launch seems to error on command launching function/functions and thus gives less information about the machine.
Changes code to only store the first bootloader telem instead of overriding it with the incomplete second one.