Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cryptojacker fixes #3567

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Cryptojacker fixes #3567

merged 2 commits into from
Aug 9, 2023

Conversation

shreyamalviya
Copy link
Contributor

@shreyamalviya shreyamalviya commented Aug 9, 2023

What does this PR do?

Issue #3411

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole nature of attempting to measure CPU usage is imprecise. At some point we'll run CPU utilization on multiple cores, and then these events won't make any sense. We need to at least make an attempt to identify the core.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping the commits that modified the event

@shreyamalviya shreyamalviya force-pushed the 3411-cryptojacker-fixes branch from 4e5aa64 to 13e2d7b Compare August 9, 2023 11:35
@mssalvatore mssalvatore force-pushed the 3411-cryptojacker-fixes branch from 13e2d7b to 383831d Compare August 9, 2023 11:53
@mssalvatore mssalvatore merged commit bd33724 into develop Aug 9, 2023
@mssalvatore mssalvatore deleted the 3411-cryptojacker-fixes branch August 9, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants