Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BB test configurations for WMI #3272

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Update BB test configurations for WMI #3272

merged 1 commit into from
Apr 28, 2023

Conversation

shreyamalviya
Copy link
Contributor

What does this PR do?

Fixes a part of #3163
Merge after the plugin is complete

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.15 🎉

Comparison is base (a153f31) 73.36% compared to head (265745f) 73.52%.

❗ Current head 265745f differs from pull request most recent head dc1abff. Consider uploading reports for the commit dc1abff to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3272      +/-   ##
===========================================
+ Coverage    73.36%   73.52%   +0.15%     
===========================================
  Files          490      484       -6     
  Lines        14333    13949     -384     
===========================================
- Hits         10516    10256     -260     
+ Misses        3817     3693     -124     

see 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shreyamalviya shreyamalviya mentioned this pull request Apr 28, 2023
10 tasks
@mssalvatore mssalvatore force-pushed the 3163-wmi-update-ete branch from 265745f to dc1abff Compare April 28, 2023 17:16
@mssalvatore mssalvatore marked this pull request as ready for review April 28, 2023 17:16
@cakekoa cakekoa merged commit 9d0d78a into develop Apr 28, 2023
@mssalvatore mssalvatore deleted the 3163-wmi-update-ete branch May 1, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants