-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3198 snmp zoo instance #3237
3198 snmp zoo instance #3237
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #3237 +/- ##
===========================================
- Coverage 73.13% 73.11% -0.02%
===========================================
Files 467 467
Lines 13681 13675 -6
===========================================
- Hits 10005 9998 -7
- Misses 3676 3677 +1 see 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
} | ||
} | ||
|
||
resource "google_compute_instance" "snmp-20" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should put this in the europe-west1-b
zone, as it has much higher quotas than europe-west3-a
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds good. I can re-generate the instances on europe-west1
. Our config currently defaults to europe-west3
-- I'll update it to point to europe-west1
by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will pointing to europe-west1 by default have unintended consequences? The BB tests have a dictionary of regions to instances.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see what is going on. Yes, it will cause issues. We have our networks split into different regions -- do you know why we do this?
Our networks:
- 10.2.0.* (tunneling2-main)
europe-west3
- 10.2.1.* (tunneling-main)
europe-west3
- 10.2.2.* (monkeyzoo-main)
europe-west3
- 10.2.3.* (monkeyzoo-main-1)
europe-west1
- 10.2.4.* (credential-reuse)
europe-west1
- 10.2.5.* (credential-reuse2)
europe-west1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The different network segments are to allow for different types of testing. But the different regions are are because, initially, everything was in west3, but we hit the CPU quota, so we started building things in west1. There hasn't been time to migrate everything to west1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. I can put the instance into europe-west1
. To fit with our existing network conventions, I should change the IP to 10.2.3.20
aba94b5
to
484b5c5
Compare
484b5c5
to
c2cc9a5
Compare
What does this PR do?
Fixes #3198.
PR Checklist
Testing Checklist