-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build AuthenticationFacade with MongoOTPRepository #3193
Conversation
87c2813
to
5232ed6
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #3193 +/- ##
===========================================
- Coverage 72.81% 72.80% -0.01%
===========================================
Files 471 471
Lines 13450 13454 +4
===========================================
+ Hits 9793 9795 +2
- Misses 3657 3659 +2 see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works; we could alternatively probably just resolve MongoOTPRepository
We'll have to register |
Resolve is not the same as register. Calling |
5232ed6
to
878e0c3
Compare
What does this PR do?
Related to #3078
PR Checklist
Was the CHANGELOG.md updated to reflect the changes?Was the documentation framework updated to reflect the changes?Testing Checklist
Added relevant unit tests?Do all end-to-end tests pass?If applicable, add screenshots or log transcripts of the feature working