Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build AuthenticationFacade with MongoOTPRepository #3193

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

shreyamalviya
Copy link
Contributor

What does this PR do?

Related to #3078

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Do all unit tests pass?
  • Do all end-to-end tests pass?
  • Any other testing performed?

    Island starts with no errors

  • If applicable, add screenshots or log transcripts of the feature working

@shreyamalviya shreyamalviya force-pushed the 3078-fix-building-AuthenticationFacade branch from 87c2813 to 5232ed6 Compare April 4, 2023 13:02
@codecov
Copy link

codecov bot commented Apr 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (9417ab4) 72.81% compared to head (5232ed6) 72.80%.

❗ Current head 5232ed6 differs from pull request most recent head 878e0c3. Consider uploading reports for the commit 878e0c3 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3193      +/-   ##
===========================================
- Coverage    72.81%   72.80%   -0.01%     
===========================================
  Files          471      471              
  Lines        13450    13454       +4     
===========================================
+ Hits          9793     9795       +2     
- Misses        3657     3659       +2     

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@cakekoa cakekoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works; we could alternatively probably just resolve MongoOTPRepository

@shreyamalviya
Copy link
Contributor Author

We'll have to register MongoOTPRepository in cc/services/initialize.py which doesn't make much sense since we don't need it anywhere else and we want to keep all the authentication hidden in the facade.

@mssalvatore
Copy link
Collaborator

We'll have to register MongoOTPRepository in cc/services/initialize.py which doesn't make much sense since we don't need it anywhere else and we want to keep all the authentication hidden in the facade.

Resolve is not the same as register. Calling container.resolve(MongoOTPRepository) should be sufficient.

@mssalvatore mssalvatore force-pushed the 3078-fix-building-AuthenticationFacade branch from 5232ed6 to 878e0c3 Compare April 4, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants