3137 UI refresh token logic #3188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilija-lazoroski
changed the base branch from
develop
to
3137-new-token-pair-endpoint
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #3188 +/- ##
==========================================
Coverage ? 72.75%
==========================================
Files ? 469
Lines ? 13424
Branches ? 0
==========================================
Hits ? 9767
Misses ? 3657
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ilija-lazoroski
force-pushed
the
3137-ui-refresh-token-logic
branch
5 times, most recently
from
1df8bd8 to
7630f4f
Compare
ilija-lazoroski
added a commit
that referenced
this pull request
Apr 3, 2023
ilija-lazoroski
force-pushed
the
3137-ui-refresh-token-logic
branch
from
7630f4f to
06d6eb7
Compare
ilija-lazoroski
added a commit
that referenced
this pull request
Apr 3, 2023
ilija-lazoroski
force-pushed
the
3137-ui-refresh-token-logic
branch
from
06d6eb7 to
12a0fa2
Compare
ilija-lazoroski
added a commit
that referenced
this pull request
Apr 3, 2023
ilija-lazoroski
force-pushed
the
3137-ui-refresh-token-logic
branch
from
12a0fa2 to
32012ef
Compare
ordabach
reviewed
Apr 3, 2023
ordabach
reviewed
Apr 3, 2023
ilija-lazoroski
added a commit
that referenced
this pull request
Apr 3, 2023
ilija-lazoroski
force-pushed
the
3137-ui-refresh-token-logic
branch
from
32012ef to
1e39f45
Compare
ilija-lazoroski
added a commit
that referenced
this pull request
Apr 3, 2023
ilija-lazoroski
force-pushed
the
3137-ui-refresh-token-logic
branch
from
1e39f45 to
68a875a
Compare
mssalvatore
force-pushed
the
3137-new-token-pair-endpoint
branch
from
315c23c to
a2ce7d3
Compare
mssalvatore
pushed a commit
that referenced
this pull request
Apr 3, 2023
mssalvatore
force-pushed
the
3137-ui-refresh-token-logic
branch
from
68a875a to
2ec7554
Compare
mssalvatore
reviewed
Apr 3, 2023
shreyamalviya
requested changes
Apr 4, 2023
ilija-lazoroski
added a commit
that referenced
this pull request
Apr 4, 2023
ilija-lazoroski
force-pushed
the
3137-ui-refresh-token-logic
branch
from
2ec7554 to
66a25d0
Compare
shreyamalviya
requested changes
Apr 4, 2023
ilija-lazoroski
added a commit
that referenced
this pull request
Apr 4, 2023
ilija-lazoroski
force-pushed
the
3137-ui-refresh-token-logic
branch
from
66a25d0 to
5619e8c
Compare
ilija-lazoroski
added a commit
that referenced
this pull request
Apr 4, 2023
ilija-lazoroski
force-pushed
the
3137-ui-refresh-token-logic
branch
from
5619e8c to
43d9db5
Compare
ilija-lazoroski
added a commit
that referenced
this pull request
Apr 4, 2023
ilija-lazoroski
force-pushed
the
3137-ui-refresh-token-logic
branch
from
43d9db5 to
5074344
Compare
ilija-lazoroski
added a commit
that referenced
this pull request
Apr 4, 2023
ilija-lazoroski
force-pushed
the
3137-ui-refresh-token-logic
branch
from
5074344 to
1c66d99
Compare
shreyamalviya
approved these changes
Apr 4, 2023
ordabach
approved these changes
Apr 4, 2023
mssalvatore
pushed a commit
that referenced
this pull request
Apr 4, 2023
mssalvatore
force-pushed
the
3137-ui-refresh-token-logic
branch
from
b2905ea to
d834c46
Compare
mssalvatore
requested changes
Apr 4, 2023
mssalvatore
reviewed
Apr 4, 2023
mssalvatore
reviewed
Apr 4, 2023
Comment on lines
+191
to
+196
| _removeTokens(tokenNameArray) { | ||
| tokenNameArray?.forEach(tokenName => { | ||
| localStorage.removeItem(tokenName); |
There was a problem hiding this comment.
Is there any reason we don't want to always remove the auth and refresh tokens together?
There was a problem hiding this comment.
Yep, there is. When we do a request and it is 401, we can immediately remove the authentication token but not the refresh token as we need it so we can generate a new token pair.
ilija-lazoroski
force-pushed
the
3137-ui-refresh-token-logic
branch
from
d834c46 to
df4fd60
Compare
|
We went a different direction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #3137 .
Add any further explanations here.
PR Checklist
Testing Checklist