Island: Add token type into token payload #3183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a new refresh token is generated, even if the old token isn't expired yet, the new one should be invalidated. We shouldn't have two valid refresh tokens for a user.
We don't revoke old refresh tokens because they expire automatically
The key should be the same in requests and responses, it's best to have a constant for it
Co-authored-by: VakarisZ <36815064+VakarisZ@users.noreply.github.com>
Extracting token owner code and explicit validation better conveys the logic
This method checks for island api user registration, not registered agents. Also, authentication_facade.py shouldn't be coupled to mongodb syntax
Token type will make sure that access tokens can't get validated for refresh tokens and vice-versa
VakarisZ
force-pushed
the
3137-token-types
branch
from
ca39605 to
16b1ab1
Compare
VakarisZ
commented
Mar 31, 2023
Comment on lines
65
to
66
| self._refresh_token_validator.validate_token(refresh_token, token_type=TokenType.REFRESH) | ||
| user_uniquifier = self._refresh_token_validator.get_token_payload(refresh_token) |
There was a problem hiding this comment.
This becomes a bit dangerous, because the user needs to call validate first. We could include the validation into payload retrieval. In that case, we should merge the TokenValidator and TokenGenerator into the TokenSerializer.
mssalvatore
force-pushed
the
3137-new-token-pair-endpoint
branch
from
315c23c to
a2ce7d3
Compare
|
We went a different direction. |
|
We went a different direction. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Token type will make sure that access tokens can't get validated for refresh tokens and vice-versa
What does this PR do?
Fixes part of #3137.
Add any further explanations here.
PR Checklist
Testing Checklist