-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Island: Include refresh token into responses #3180
Conversation
46dc521
to
25770e0
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #3180 +/- ##
===========================================
+ Coverage 72.48% 72.50% +0.02%
===========================================
Files 467 467
Lines 13285 13295 +10
===========================================
+ Hits 9630 9640 +10
Misses 3655 3655 see 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Travis fails
Missing unit tests
|
||
def add_refresh_token_to_response(response: Response, refresh_token: Token) -> Response: | ||
""" | ||
Adds a refresh token to the response |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adds a refresh token to the response | |
Returns a copy of the response object with a refresh token added to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Login and registration should respond with a token pair
08e396a
to
7b68728
Compare
What does this PR do?
Fixes part of #3137.
Login and registration should respond with a token pair
PR Checklist
Testing Checklist