Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update network scanning documentation #2357

Merged
merged 2 commits into from
Sep 27, 2022

Conversation

cakekoa
Copy link
Contributor

@cakekoa cakekoa commented Sep 27, 2022

What does this PR do?

Fixes part of #2299.

Updates the documentation for the "Scan Agent's networks" option.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?
  • Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • If applicable, add screenshots or log transcripts of the feature working

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Base: 60.40% // Head: 60.56% // Increases project coverage by +0.16% 🎉

Coverage data is based on head (e63409d) compared to base (8b8ef79).
Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2357      +/-   ##
===========================================
+ Coverage    60.40%   60.56%   +0.16%     
===========================================
  Files          539      540       +1     
  Lines        14075    14090      +15     
===========================================
+ Hits          8502     8534      +32     
+ Misses        5573     5556      -17     
Impacted Files Coverage Δ
...agent_configuration/default_agent_configuration.py 100.00% <ø> (ø)
monkey/infection_monkey/master/propagator.py 99.00% <ø> (+<0.01%) ⬆️
...nkey/monkey_island/cc/services/reporting/report.py 25.64% <0.00%> (ø)
...on/agent_configuration/agent_sub_configurations.py 100.00% <100.00%> (ø)
...n_monkey/network_scanning/scan_target_generator.py 100.00% <100.00%> (ø)
monkey/tests/common/example_agent_configuration.py 100.00% <100.00%> (ø)
...ection_monkey/post_breach/custom_pba/custom_pba.py 62.29% <0.00%> (-1.04%) ⬇️
monkey/infection_monkey/monkey.py 0.00% <0.00%> (ø)
monkey/common/agent_events/__init__.py 100.00% <0.00%> (ø)
monkey/monkey_island/cc/models/agent.py 100.00% <0.00%> (ø)
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cakekoa cakekoa force-pushed the 2299-update-network-config-docs branch from bdde5fc to e63409d Compare September 27, 2022 14:39
@cakekoa cakekoa merged commit ea94da9 into develop Sep 27, 2022
@cakekoa cakekoa deleted the 2299-update-network-config-docs branch September 27, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants