Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove environments #1620

Merged
merged 9 commits into from
Nov 22, 2021
Merged

Remove environments #1620

merged 9 commits into from
Nov 22, 2021

Conversation

mssalvatore
Copy link
Collaborator

@mssalvatore mssalvatore commented Nov 19, 2021

What does this PR do?

Fixes #1560

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested by running AppImage and Docker black box tests.
    Tested by runnning in AWS and verifying that Monkey Island detects it is running in AWS

  • If applicable, add screenshots or log transcripts of the feature working

@mssalvatore mssalvatore requested review from VakarisZ, shreyamalviya and ilija-lazoroski and removed request for VakarisZ November 19, 2021 15:42
@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #1620 (69cbf3f) into develop (ee285b6) will decrease coverage by 0.34%.
The diff coverage is 38.46%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1620      +/-   ##
===========================================
- Coverage    44.86%   44.52%   -0.35%     
===========================================
  Files          469      462       -7     
  Lines        13622    13625       +3     
===========================================
- Hits          6112     6066      -46     
- Misses        7510     7559      +49     
Impacted Files Coverage Δ
monkey/monkey_island/cc/server_setup.py 0.00% <0.00%> (ø)
...monkey_island/cc/server_utils/bootloader_server.py 0.00% <0.00%> (ø)
...s/unit_tests/monkey_island/cc/services/conftest.py 100.00% <ø> (ø)
...nkey/monkey_island/cc/services/run_local_monkey.py 40.00% <50.00%> (-1.67%) ⬇️
monkey/monkey_island/cc/app.py 79.85% <66.66%> (+0.15%) ⬆️
monkey/monkey_island/cc/server_utils/consts.py 93.10% <100.00%> (+0.24%) ⬆️
monkey/monkey_island/cc/services/config.py 53.02% <100.00%> (ø)
monkey/tests/unit_tests/monkey_island/conftest.py 92.30% <0.00%> (-7.70%) ⬇️
monkey/infection_monkey/monkey.py 0.00% <0.00%> (ø)
monkey/infection_monkey/config.py 65.21% <0.00%> (+3.80%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee285b6...69cbf3f. Read the comment docs.

@mssalvatore mssalvatore marked this pull request as ready for review November 19, 2021 17:48
Copy link
Contributor

@ilija-lazoroski ilija-lazoroski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need Changelog entry and it LGTM.

@mssalvatore
Copy link
Collaborator Author

We just need Changelog entry and it LGTM.

@ilija-lazoroski This doesn't need a changelog entry. It's a purely internal change and has no meaningful impact on users or developers.

@mssalvatore mssalvatore merged commit f457635 into develop Nov 22, 2021
@mssalvatore mssalvatore deleted the 1506-remove-environments branch November 22, 2021 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Environment classes
3 participants