Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package appimage with linuxdeploy #1381

Merged
merged 3 commits into from
Jul 31, 2021

Conversation

mssalvatore
Copy link
Collaborator

@mssalvatore mssalvatore commented Jul 29, 2021

What does this PR do?

Fixes #1355
Fixes #1362

Add any further explanations here.

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?

Testing Checklist

  • Have you successfully tested your changes locally? Elaborate:

    Tested by running on Ubuntu Bionic, Ubuntu Focal, and Rocky 8

@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #1381 (762d398) into develop (b4d97d1) will not change coverage.
The diff coverage is n/a.

❗ Current head 762d398 differs from pull request most recent head 1148836. Consider uploading reports for the commit 1148836 to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1381   +/-   ##
========================================
  Coverage    39.80%   39.80%           
========================================
  Files          466      466           
  Lines        13808    13808           
========================================
  Hits          5496     5496           
  Misses        8312     8312           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4d97d1...1148836. Read the comment docs.

Comment on lines 99 to 101
unlink "$APPDIR"/python.png
unlink "$APPDIR"/python*.desktop
unlink "$APPDIR"/AppRun
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why unlink instead or rm?

Copy link
Collaborator Author

@mssalvatore mssalvatore Jul 31, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably because some of them were symlinks, and I use unlink for symlinks instead of rm; not because it does anything substantively different, just because that's how my brain works. I can make them rm instead.

@mssalvatore mssalvatore force-pushed the package-appimage-with-linuxdeploy branch from 762d398 to 1148836 Compare July 31, 2021 23:20
@mssalvatore mssalvatore merged commit 1194834 into develop Jul 31, 2021
@mssalvatore mssalvatore deleted the package-appimage-with-linuxdeploy branch July 31, 2021 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add libcurl to Appimage MongoDB is not starting on CentOS 7
2 participants