Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config export modal #1189

Merged
merged 3 commits into from
May 28, 2021
Merged

Config export modal #1189

merged 3 commits into from
May 28, 2021

Conversation

VakarisZ
Copy link
Contributor

What does this PR do?

Creates a modal window/popup for configuration export.

Mockup:
image

Results:
image

PR Checklist

  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Is the TravisCI build passing?
  • Was the CHANGELOG.md updated to reflect the changes?
  • Was the documentation framework updated to reflect the changes?

Testing Checklist

  • Added relevant unit tests?
  • Have you successfully tested your changes locally? Elaborate:

    Tested manually, by using all of the functionality in the popup: close modal, enter password, switch to plaintext, switch back to password, etc.

  • If applicable, add screenshots or log transcripts of the feature working

@VakarisZ VakarisZ requested a review from shreyamalviya May 28, 2021 08:02
@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #1189 (a0487f4) into develop (243642c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1189   +/-   ##
========================================
  Coverage    28.83%   28.83%           
========================================
  Files          424      424           
  Lines        12893    12893           
========================================
  Hits          3718     3718           
  Misses        9175     9175           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 243642c...a0487f4. Read the comment docs.

@VakarisZ VakarisZ merged commit badcd0e into develop May 28, 2021
@VakarisZ VakarisZ deleted the config_export_popup branch May 28, 2021 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants