Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate SSH credentials collector to a plugin #3169

Closed
12 tasks done
mssalvatore opened this issue Mar 28, 2023 · 0 comments
Closed
12 tasks done

Migrate SSH credentials collector to a plugin #3169

mssalvatore opened this issue Mar 28, 2023 · 0 comments
Labels
Complexity: High Complexity: Medium Credentials Collector Plugins Refactor sp/8
Milestone
v2.2.0

Comments

@mssalvatore
Copy link
Collaborator

mssalvatore commented Mar 28, 2023 •
edited
Loading

Description

Migrate the SSH credentials collector to a plugin.#3167
Completion of this issue closes #1882

Tasks

  • Modify SSHKeypair.public_key to be optional (0d) @ilija-lazoroski
  • Migrate the existing collector to a plugin (0d) @mssalvatore
  • Refactor flawed logic (0.25d) @mssalvatore
    • Address TODOs in code
    • Redesign the search file algorithm.
      • Use the passwd library to identify all home directories and .ssh directories
      • For each .ssh directory find all private key files (See this for example how to identify private keys)
      • For each private key attempt to identify a public key (Note: Each private key may not have a public key)
  • Remove the hard-coded SSH credentials collector plugin (0d)
  • Add a jenkins job to build the plugin. @mssalvatore
  • Add the plugin artifact to the Island build jobs
  • Remove any references to hard-coded credentials collectors, their manifests, etc.
@mssalvatore mssalvatore added this to the v2.2.0 milestone Mar 28, 2023
@ilija-lazoroski ilija-lazoroski mentioned this issue Apr 24, 2023
Closed
@ilija-lazoroski ilija-lazoroski mentioned this issue May 9, 2023
Merged
10 tasks
mssalvatore added a commit that referenced this issue May 9, 2023
@mssalvatore
Merge branch '3169-ssh-keypair-publi-key-optional' into develop
9de1ccd 
Issue #3169
PR #3320
mssalvatore added a commit that referenced this issue May 9, 2023
@mssalvatore
Changelog: Add an entry for #3169
d9fd31a
mssalvatore added a commit that referenced this issue May 9, 2023
@mssalvatore
Merge branch '3169-remove-hardcoded-ssh-collector' into 3169-migrate-…
fe54455 
…ssh-collector-to-plugin

Issue #3169
PR #3326
mssalvatore added a commit that referenced this issue May 9, 2023
@mssalvatore
Merge branch '3169-migrate-ssh-collector-to-plugin' into develop
1716b2e 
Issue #3169
@ilija-lazoroski ilija-lazoroski mentioned this issue May 10, 2023
Merged
10 tasks
mssalvatore added a commit that referenced this issue May 10, 2023
@mssalvatore
Merge branch '3169-improve-search-algorithm' into develop
9f49792 
Issue #3169
PR #3329

Fixes #1882
mssalvatore added a commit that referenced this issue May 11, 2023
@mssalvatore
Merge branch '3169-fix-pwd-import-windows' into develop
001b74e 
Issue #3169

See PR #3331
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Complexity: High Complexity: Medium Credentials Collector Plugins Refactor sp/8
Projects
None yet
Milestone
v2.2.0
Development

No branches or pull requests
1 participant
@mssalvatore