Use latest corepack #2666
Merged
Use latest corepack #2666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We started seeing issues with pnpm signatures, which is apparently fixed with a later corepack release. See pnpm/pnpm#9014
andrewHEguardian
approved these changes
Feb 3, 2025
rupertbates
approved these changes
Feb 3, 2025
johnduffell
approved these changes
Feb 3, 2025
I'm actually not sure about this. I think I'll merge to unblock things and investigate as a possible follow up optimisation. |
It wasn't necessarily a suggestion, I just wondered why the flag was needed (if at all) given that we get a fresh runner every time. |
andrewHEguardian
added a commit
to guardian/csnx
that referenced
this pull request
Feb 3, 2025
## What are you changing? - Use a specific version of corepack ## Why? - The build is failing, see pnpm/pnpm#9014. This is a proposed fix also used in guardian/support-service-lambdas#2666
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Uses a more recent version of corepack in CI.
We started seeing issues with pnpm signatures, which is apparently fixed with a later corepack release.
See pnpm/pnpm#9014
How to test
Ensure the build passes.