Adopt GitHub Actions for CI #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also switches from deprecated sbt-riffraff-artifact plugin to devx recommendation guardian/actions-riff-raff. Based on guardian/mobile-n10n#1151 and guardian/s3-upload#53
davidfurey
changed the title
|
I've done a cursory test in CODE, adding and removing an article from a story package |
Comment on lines
+37
to
+38
| java-version: '8' | ||
| distribution: 'corretto' |
There was a problem hiding this comment.
Adding cache: 'sbt' here is apparently helpful for performance, I learnt here.
.github/workflows/ci.yml
Outdated
| id-token: write | ||
| contents: read | ||
| steps: | ||
| - uses: actions/checkout@v3 |
.github/workflows/ci.yml
Outdated
| steps: | ||
| - uses: actions/checkout@v3 | ||
|
|
||
| - uses: aws-actions/configure-aws-credentials@v2 |
.github/workflows/ci.yml
Outdated
| grunt --stack bundle | ||
|
|
||
| - name: SBT | ||
| run: sbt "clean;compile;test;assets;Debian / packageBin" |
There was a problem hiding this comment.
Just a note on batch mode, apparently it makes builds run more slowly. Having said that, this discussion suggests that these sbt commands will run in batch mode, and sequentially (i.e. no need for semicolons either), anyway.
I believe you can also remove the space and have Debian/packageBin, to remove the need for quotes.
|
Thanks @samanthagottlieb, I'll merge+deploy tomorrow |
|
Seen on PROD (merged by @davidfurey 7 minutes and 36 seconds ago) Please check your changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This change adopt GitHub Actions for CI, replacing TeamCity which DevX are switching off in Q2 2023.
This change isn't exactly a no-op switch, as the
sbt-riffraff-artifactplugin has been removed in favour ofguardian/actions-riff-raff.How to test
Notes
.debfilesize is different between build 187 and build 191, but unzipping yields no differences so I presume this is a quirk of the zip compression