Update to fapi-client v4.0.6 #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a small upgrade, catching up with the recent dependency updates of https://github.com/guardian/facia-scala-client/releases/tag/v4.0.6, before the more extensive update in guardian/facia-scala-client#287 is introduced. This update has already been tested in Ophan's PromotionPoller with guardian/ophan#5540, successfully deployed to Prodution.
Georges-GNM
reviewed
Sep 13, 2023
| @@ -90,7 +90,7 @@ libraryDependencies ++= jacksonOverrides ++ Seq( | |||
| "com.typesafe.play" %% "play-json" % "2.9.4", | |||
| "com.typesafe.play" %% "play-iteratees" % "2.6.1", | |||
| "org.julienrf" %% "play-json-derived-codecs" % "10.1.0", | |||
| "org.scalatest" %% "scalatest" % "3.2.15" % "test" | |||
| "org.scalatest" %% "scalatest" % "3.2.15" % Test | |||
There was a problem hiding this comment.
Just curious, because I can see some sbt files use Test and others "test", which I think the docs also suggest that - does this make any practical difference?
There was a problem hiding this comment.
The value of Test is just the string "test" - it just means that if you mistype the name of a variable, the compiler will tell you straight away, but if you're typing the string, it might not be so obvious!
rtyley
added a commit
that referenced
this pull request
Sep 15, 2023
This is prompted by the outage caused by #184, where new PROD instances of https://packages.gutools.co.uk/ couldn't start up. Although more specific testing would catch this issue before it went live, as a last resort, it's good to know that a pull request has _not_ gone live after merging, and that's one of the things Prout can help with - posting a 'OVERDUE' message against the PR. See also: * https://github.com/guardian/prout * https://www.theguardian.com/info/developer-blog/2015/feb/03/prout-is-your-pull-request-out * Other examples of configuring Prout: * guardian/mobile-apps-api#2507 * guardian/apple-news#232
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small upgrade, catching up with the recent dependency updates of https://github.com/guardian/facia-scala-client/releases/tag/v4.0.6, before the more extensive update in guardian/facia-scala-client#287 is introduced.
This update has already been tested in Ophan's PromotionPoller with https://github.com/guardian/ophan/pull/5540, successfully deployed to Prodution.