Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly install sbt in dependency submission workflow #1164

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

tjsilver
Copy link
Contributor

@tjsilver tjsilver commented Oct 15, 2024

What does this change?

  • Installs sbt in the dependency submission workflow.

What is the value of this?

The workflow is currently broken because the latest Ubuntu doesn't come with sbt bundled.

How to test

This is the workflow run before and after this change.

  • TODO: remove this branch from the workflow

on:
push:
branches:
- main # default branch of the project
- main
workflow_dispatch:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking: was this left in intentionally?

Copy link
Contributor Author

@tjsilver tjsilver Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it just matches what dep graph integrator pr generator produces now (i.e. without the comment) and with workflow_dispatch trigger

@tjsilver tjsilver merged commit d6e90fe into main Oct 16, 2024
4 checks passed
@tjsilver tjsilver deleted the ts/fix-dependency-submission-workflow branch October 16, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants