fix: Report build number correctly #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're currently using the environment variable `GITHUB_RUN_NUMBER` to determine the build number for build info. `GITHUB_RUN_NUMBER` is not offset by the number of builds of this project previously performed by TeamCity. This change creates a new environment variable `BUILD_NUMBER` which is `GITHUB_RUN_NUMBER` + the TeamCity offset.
jacobwinch
approved these changes
Nov 3, 2023
|
This is working as expected on PROD: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
We're currently using the environment variable
GITHUB_RUN_NUMBERto determine the build number for build info.GITHUB_RUN_NUMBERis not offset by the number of builds of this project previously performed by TeamCity.This change creates a new environment variable
BUILD_NUMBERwhich isGITHUB_RUN_NUMBER+ the TeamCity offset.The screenshot below taken from PROD, suggests we're running build 804, when in fact we are running build 3164 (804 + 2360).
When deployed to CODE, we get the correct number:
Builds on #1229.
Inspired by https://github.com/guardian/flexible-content/pull/4382.