Persist session and cookies set on result #35
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in most code paths the filter constructs a new Result object with updated body and headers, which means that any new session or cookies previously set on the result will be dropped. The impact of this can currently be seen on the CV redact tool, which cannot pass CSRF checks because the session is never sent to the user's browser, so the CSRF token sent with the submission cannot be verified.
Instead, copy the Result to insert the updated headers and body without dropping other values set on the Result.