Keep test console output when junit output is used #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtyley
reviewed
Aug 1, 2024
rtyley
reviewed
Aug 1, 2024
emdash-ie
force-pushed
the
improve-test-output
branch
from
89352eb
to
b95a9ca
Compare
Before now, scalatest’s output was never sent to standard out: the default behaviour when passing the “-u” flag is to omit it. This is a bit irritating when running locally, because it makes it hard to tell which tests have failed. This commit changes the behaviour to always send scalatest’s output to standard out, as well as writing to junit files. This lets us keep the benefits of the XML output in CI (annotations pointing to the source files), while making the tests more useful when run locally.
It’s shorter and neater! Co-authored-by: Roberto Tyley <52038+rtyley@users.noreply.github.com>
emdash-ie
force-pushed
the
improve-test-output
branch
from
b95a9ca
to
204394d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before now, scalatest’s output was never sent to standard out: the default behaviour when passing the “-u” flag is to omit it. This is a bit irritating when running locally, because it makes it hard to tell which tests have failed.
This commit changes the behaviour to always send scalatest’s output to standard out, as well as writing to junit files.
This lets us keep the benefits of the XML output in CI (annotations pointing to the source files), while making the tests more useful when run locally.
This PR is a copy of the changes @fredex42 and I made to crier in https://github.com/guardian/crier/pull/174 (specifically commit https://github.com/guardian/crier/commit/59206fae5b65b5ece9b83df65f1b3bcba1637155)