Linting

[oliverlloyd]

What does this change?

Well, this mushroomed.

Originally a PR to add linting it grew into adding additional config packages to get linting to work and then I had to do that thing where you have to solve all the linting errors causing a cascade of changes.

What linting errors were there?

Most changes were classic things like single quotes vs. double or spacing but the recommended configuration for @guardian repos also has things like no default exports which caused errors here too

I also updated the scripts section of package.json, giving:

    "lint": "eslint . --ext .ts,.tsx",
    "test": "jest",
    "tsc": "tsc",
    "validate": "npm run lint && npm run test && npm run tsc",

[mxdvl]

Do you need both .eslintrc and .prettierrc?

Should we also add the .editorconfig? https://github.com/guardian/configs/blob/main/.editorconfig

[mxdvl]

Is this going to work?

[oliverlloyd]

In the same file further up, we're already doing export { Role } from './image'; so export { Img } from './components/img'; should work the same.

[oliverlloyd]

Do you need both .eslintrc and .prettierrc?

To be honest, I've never really got my head around how and where eslint and prettier overlap. I'm used to having the two different config files though and the onfigs repo seems to take the same approach so I'm happy to defer to the standard path

Should we also add the .editorconfig? https://github.com/guardian/configs/blob/main/.editorconfig

I think this makes sense. We could perhaps bring this in in a different PR to try to limit the noice from this one

[mxdvl]

Glad I'm not the only one struggling to grasp the distinction between Prettier and ESLint 😆

I think it should be set up so that prettier runs after ESLint, possibly triggered by it.

[gtrufitt]

🆒

[oliverlloyd]

Linting for IR