Create 0% test to use non-lite versions of fronts #27389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielCliftonGuardian
approved these changes
Aug 22, 2024
| @@ -135,11 +136,13 @@ trait FaciaController | |||
| FrontHeadline.headlineNotFound | |||
| } | |||
|
|
|||
| val requestType = if (ActiveExperiments.isParticipating(RemoveLiteFronts)) liteRequestType else fullRequestType | |||
There was a problem hiding this comment.
Could we extract this to avoid repetition ?
ioannakok
reviewed
Aug 22, 2024
| @@ -180,7 +183,9 @@ trait FaciaController | |||
| Cached(CacheTime.Facia)(JsonComponent.fromWritable(JsObject(Nil))), | |||
| ) | |||
| } else { | |||
| frontJsonFapi.get(path, liteRequestType).map { resp => | |||
| val requestType = if (ActiveExperiments.isParticipating(RemoveLiteFronts)) liteRequestType else fullRequestType | |||
There was a problem hiding this comment.
Perhaps I'm completely misreading this but shouldn't this be the other way around? If it participates in the test we request the full front otherwise we keep on requesting the lite version.
Suggested change
| val requestType = if (ActiveExperiments.isParticipating(RemoveLiteFronts)) liteRequestType else fullRequestType | |
| val requestType = if (ActiveExperiments.isParticipating(RemoveLiteFronts)) fullRequestType else liteRequestType |
Same question for the other places where we make this check and +1 to @DanielCliftonGuardian's proposal to extract this.
There was a problem hiding this comment.
You're right, I have it the wrong way around!
ioannakok
reviewed
Aug 22, 2024
| @@ -220,7 +225,10 @@ trait FaciaController | |||
|
|
|||
| import PressedPage.pressedPageFormat | |||
| private[controllers] def renderFrontPressResult(path: String)(implicit request: RequestHeader): Future[Result] = { | |||
| val futureFaciaPage: Future[Option[(PressedPage, Boolean)]] = frontJsonFapi.get(path, liteRequestType).flatMap { | |||
| val requestType = if (ActiveExperiments.isParticipating(RemoveLiteFronts)) liteRequestType else fullRequestType | |||
| val NonAdFreeType = if (ActiveExperiments.isParticipating(RemoveLiteFronts)) LiteType else FullType | |||
There was a problem hiding this comment.
Suggested change
| val NonAdFreeType = if (ActiveExperiments.isParticipating(RemoveLiteFronts)) LiteType else FullType | |
| val NonAdFreeType = if (ActiveExperiments.isParticipating(RemoveLiteFronts)) FullType else LiteType |
?
| @@ -527,6 +530,8 @@ trait FaciaController | |||
| if (request.isAdFree) FullAdFreeType else FullType | |||
| def liteRequestType(implicit request: RequestHeader): PressedPageType = | |||
| if (request.isAdFree) LiteAdFreeType else LiteType | |||
| def requestType(implicit request: RequestHeader): PressedPageType = | |||
| if (ActiveExperiments.isParticipating(RemoveLiteFronts)) fullRequestType else fullRequestType | |||
There was a problem hiding this comment.
Suggested change
| if (ActiveExperiments.isParticipating(RemoveLiteFronts)) fullRequestType else fullRequestType | |
| if (ActiveExperiments.isParticipating(RemoveLiteFronts)) fullRequestType else liteRequestType |
|
Tested locally and on CODE |
|
Seen on FRONTS-PROD, ADMIN-PROD (merged by @domlander 11 minutes and 30 seconds ago)
|
This was referenced Aug 27, 2024
domlander
changed the title
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the value of this and can you measure success?
The first step towards removing the lite versions of pressed fronts, to free up memory
What does this change?
Introduces an experiment that will use the regular version of the pressed front as opposed to the lite version.