Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Lightbox for all #26847

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Enable Lightbox for all #26847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions common/app/conf/switches/JournalismSwitches.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,4 +62,14 @@ trait JournalismSwitches {
sellByDate = never,
exposeClientSide = false,
)

val Lightbox = Switch(
SwitchGroup.Journalism,
name = "lightbox",
description = "Enable lightbox for images",
owners = Seq(Owner.withEmail("dotcom.platform@theguardian.com")),
safeState = On,
sellByDate = never,
exposeClientSide = true,
)
}
10 changes: 0 additions & 10 deletions common/app/experiments/Experiments.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import java.time.LocalDate
object ActiveExperiments extends ExperimentsDefinition {
override val allExperiments: Set[Experiment] =
Set(
Lightbox,
AdaptiveSite,
OfferHttp3,
DeeplyRead,
Expand All @@ -28,15 +27,6 @@ object DeeplyRead
participationGroup = Perc0A,
)

object Lightbox
extends Experiment(
name = "lightbox",
description = "Testing the impact lightbox might have on our CWVs",
owners = Seq(Owner.withEmail("dotcom.platform@theguardian.com")),
sellByDate = LocalDate.of(2024, 1, 31),
participationGroup = Perc5A,
)

// Removing while we are still implementing this content type in DCR
//object DCRImageContent
// extends Experiment(
Expand Down
Loading