Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include overlay changes #26239

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Include overlay changes #26239

merged 2 commits into from
Jun 26, 2023

Conversation

sophie-macmillan
Copy link
Contributor

What does this change?

This cherrypicks the overlay changes from #26193. Initially we wanted the videos to play on small screens, but now it just updates the video overlay.

Does this change need to be reproduced in dotcom-rendering ?

Screenshots

Before After
image image

@sophie-macmillan sophie-macmillan marked this pull request as ready for review June 26, 2023 11:04
@sophie-macmillan sophie-macmillan requested a review from a team as a code owner June 26, 2023 11:04
marjisound
marjisound approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@marjisound marjisound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

@marjisound
Copy link
Contributor

marjisound commented Jun 26, 2023 •
edited
Loading

@sophie-macmillan I think for the build error we need to update the test "Youtube template" should "include duration" in AtomCleanerTest to expect a span rather than just the duration
should be("0:36") should be replaced by should be("<span>0:36</span>")

@sophie-macmillan sophie-macmillan force-pushed the sophie-m/youtube-overlay-changes branch from b6df60b to 5686453 Compare June 26, 2023 12:04
@sophie-macmillan
Copy link
Contributor Author

Thanks @marjisound, have fixed with an includes instead :)

@abeddow91 abeddow91 force-pushed the sophie-m/youtube-overlay-changes branch from 5686453 to cc9bd6e Compare June 26, 2023 14:49
@sophie-macmillan sophie-macmillan merged commit f8a8c62 into ab/video-card-design-update Jun 26, 2023
@sophie-macmillan sophie-macmillan deleted the sophie-m/youtube-overlay-changes branch June 26, 2023 15:16
abeddow91 pushed a commit that referenced this pull request Jun 27, 2023
@sophie-macmillan @abeddow91
Include overlay changes (#26239)
a9e521c 
* Include style changes for updated video design

* Move duration pill on non playable videos
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marjisound marjisound marjisound approved these changes

@abeddow91 abeddow91 abeddow91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sophie-macmillan @marjisound @abeddow91