On fronts, prioritise replacement images over cutouts for pieces with the Comment tone

[jonathonherbert]

What does this change?

Bumps fapi-client from 4.0.1 to 4.0.2. This includes a fix where images that have been replaced in the Fronts tool do not correctly override cutouts in pieces with the Comment tone.

For more details, see the relevant PR.

How to test

Deploy to CODE, and add a piece with a Comment tone to a front in CODE. Preview the front. Prior to this change, you will not be able to replace the image in the fronts tool. After it, that should work.

Does this change need to be reproduced in dotcom-rendering ?

I'm not sure – my assumption would that the DCR fronts renderer uses the output of fapi-client. If that's not the case, let's reconsider.

Screenshots

Before	After

What is the value of this and can you measure success?

This should forestall the e-mail we get every few months or so from a rightly confused Fronts editor.

Checklist

Does this affect other platforms?

• AMP
• Apps
• Other (please specify)

Does this affect GLabs Paid Content Pages? Should it have support for Paid Content?

• No
• Yes (please give details)

Does this change break ad-free?

• No
• It did, but tests caught it and I fixed it
• It did, but there was no test coverage so I added that then fixed it

Does this change update the version of CAPI we're using?

• No, all the existing database files are just fine
• Yes, and I have re-run all the tests locally and checked in all the updated data/database/xyz files

Accessibility test checklist

• Tested with screen reader
• Navigable with keyboard
• Colour contrast passed

Tested

• Locally
• On CODE (optional)

[oliverlloyd]

Do you see the same overridden image in your test when adding ?dcr to the end of the url?

[jonathonherbert]

I'll check – for my own understanding, does DCR use the output of facia-press?

edit: no, DCR doesn't do this – at the time of writing, https://m.code.dev-theguardian.com/jon and https://m.code.dev-theguardian.com/jon?dcr differ in that DCR does not override correctly.

[AshCorr]

Happy to approve to get this issue fixed. Would be good to investigate why this doesn't work on DCR though, it also uses the output of facia-press so its a bit weird that this doesn't fix it in DCR. Raised guardian/dotcom-rendering#6028

[prout-bot]

Seen on PROD (merged by @jonathonherbert 16 minutes and 37 seconds ago)

• Check your changes on www.theguardian.com ✔️
• Keep an eye on the deploy dashboard 📉