Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: More logical tab order for podcasts #25287

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Conversation

AshCorr
Copy link
Member

@AshCorr AshCorr commented Jul 26, 2022

What does this change?

Updates tab order to be a bit more logical. Order should be top to bottom, left to right.

Closes guardian/dotcom-rendering#5033

Does this change need to be reproduced in dotcom-rendering ?

  • No
  • Yes (please indicate your plans for DCR Implementation)

Screenshots

Before After
before after

Co-authored-by: Ioanna Kokkini <ioannakok@hotmail.com>
@AshCorr AshCorr marked this pull request as ready for review July 26, 2022 15:23
@AshCorr AshCorr requested a review from a team as a code owner July 26, 2022 15:23
Copy link
Contributor

@bryophyta bryophyta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, although I spent a bit too long trying to work out which app to run too render it locally so I haven't been able to actually test the output!

Copy link
Contributor

@mxdvl mxdvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elegant!

@AshCorr AshCorr merged commit 60f0136 into main Aug 10, 2022
@AshCorr AshCorr deleted the a11y/PodcastIllogicalTabOrder branch August 10, 2022 09:33
@prout-bot
Copy link
Collaborator

Seen on PROD (merged by @AshCorr 5 hours, 15 minutes and 18 seconds ago)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue ID: DAC_Illogical_Tab_Order3
4 participants