Commits on Jun 30, 2022

1. Update CAPI & FAPI clients (also remove Lightbox hack) …

   The latest version of the CAPI client (v19) includes
   guardian/content-api-scala-client#359,
   which we can use to replace the pagination code based on `play-iteratees`
   (https://github.com/playframework/play-iteratees - introduced in July 2014
   with #5199), currently blocking the
   Scala 2.13 upgrade for Frontend (see #24817).
   
   The updated CAPI client is binary-incompatible with previous versions of
   the CAPI client, meaning we also need to update the FAPI client as it also
   uses CAPI. A similar PR updating FAPI & CAPI in Ophan is at
   guardian/ophan#4719. Like there, we're adding a
   test that will break at build time rather than runtime if our versions of
   the FAPI & CAPI clients are incompatible.
   
   The updates to the CAPI client also support `previous`/`next` search
   functionality, as used by the Lightbox, meaning that the small
   `ContentApiNavQuery` hack for the Lightbox (introduced here:
   #20462) can now be removed.
   
   See also:
   
   * #25139 (comment)
   * https://github.com/guardian/ophan/pull/4719/files#diff-ee7f97c92065084bba37d70d043ad0daa0d7745f235d0ad3206b59f073829529
   
   Co-authored-by: Roberto Tyley <roberto.tyley@guardian.co.uk>

   

   ioannakok and rtyley committed Jun 30, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for 0025248
   • Browse repository at this point

   Copy the full SHA

   0025248 View commit details

   Browse the repository at this point in the history