Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add elementId to main media elements #23571

Merged
merged 3 commits into from
Feb 25, 2021
Merged

Add elementId to main media elements #23571

merged 3 commits into from
Feb 25, 2021

Conversation

shtukas
Copy link
Contributor

@shtukas shtukas commented Feb 25, 2021

What does this change?

Add elementId to main media elements. (Natural follow up of #23562)

Screenshot 2021-02-25 at 08 42 55

Copy link
Contributor

@oliverlloyd oliverlloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PRBuilds
Copy link

PRbuilds results:

Screenshots
wide.pngdesktop.pngtablet.pngmobile.png

💚 A11y validation
a11y-report.txt

💚 Microdata Validation
microdata.txt

Apache Benchmark Load Testing
loadtesting.txt

LightHouse Reporting
1614243832.report.html

--automated message

@shtukas shtukas merged commit 5d93aa7 into main Feb 25, 2021
@shtukas shtukas deleted the ph-20210225-0834-renderId branch February 25, 2021 09:07
@prout-bot
Copy link
Collaborator

Seen on PROD (merged by @shtukas 18 minutes and 54 seconds ago)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants