Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .git to end of dotcom-rendering repo #21159

Merged
merged 2 commits into from
Feb 26, 2019
Merged

Add .git to end of dotcom-rendering repo #21159

merged 2 commits into from
Feb 26, 2019

Conversation

gtrufitt
Copy link
Contributor

What does this change?

Adds .git to end of the DC repo

What is the value of this and can you measure success?

Aiming to fix:

[Step 3/8] error https://registry.yarnpkg.com/acorn/-/acorn-5.4.1.tgz: Extracting tar content of undefined failed, the file appears to be corrupt: "Invalid tar header. Maybe the tar is corrupted or it needs to be gunzipped?"

in teamcity using the fix described yarnpkg/yarn#6312

make reinstall works locally.

@gtrufitt
Copy link
Contributor Author

ok nope

@PRBuilds
Copy link

PRBuilds commented Feb 26, 2019 •
edited
Loading

PRbuilds results:

Screenshots
wide.png • desktop.png • tablet.png • mobile.png

💚 Exceptions
thrown-exceptions.js

💚 A11y validation
a11y-report.txt

💚 Microdata Validation
microdata.txt

Apache Benchmark Load Testing
loadtesting.txt

LightHouse Reporting
1551197117.report.html

--automated message

@gtrufitt
Copy link
Contributor Author

ok yup

@janua
Copy link
Contributor

janua commented Feb 26, 2019

👍

@gtrufitt gtrufitt merged commit 249f77b into master Feb 26, 2019
@gtrufitt gtrufitt deleted the gtrufitt-patch-2 branch February 26, 2019 15:53
@gtrufitt gtrufitt restored the gtrufitt-patch-2 branch February 26, 2019 15:59
@prout-bot
Copy link
Collaborator

Overdue on PROD (merged by @gtrufitt 30 minutes and 8 seconds ago) What's gone wrong?

@prout-bot
Copy link
Collaborator

Seen on PROD (merged by @gtrufitt 34 minutes and 46 seconds ago)

@ripecosta ripecosta deleted the gtrufitt-patch-2 branch November 12, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@regiskuckaertz regiskuckaertz regiskuckaertz approved these changes

@shtukas shtukas shtukas approved these changes

@nicl nicl Awaiting requested review from nicl

@SiAdcock SiAdcock Awaiting requested review from SiAdcock

Assignees
No one assigned
Labels
Seen-on-PROD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gtrufitt @PRBuilds @janua @prout-bot @regiskuckaertz @shtukas