Use lite pressed fronts in Facia #18365
Conversation
QuarpT
changed the title
|
PRbuilds results: Screenshots 💚 Exceptions 💚 A11y validation Apache Benchmark Load Testing 💚 Microdata Validation --automated message |
| @@ -218,13 +218,13 @@ trait FaciaController extends BaseController with Logging with ImplicitControlle | |||
|
|
|||
| private def getPressedCollection(collectionId: String): Future[Option[PressedCollection]] = | |||
There was a problem hiding this comment.
Are we sure this function is not used by endpoints that requires the full pressed file? Same question below for getSomeCollections?
There was a problem hiding this comment.
I'm not certain. We need to list the endpoints require the full PressedPage.
For this PR, I've assumed that only /*path/show-more/*id.jsonand /*path/deduped.json require the full version.
There was a problem hiding this comment.
let's try to figure it out. Let me know if you need any help.
…r_show_more_and_lite
…r_show_more_and_lite
…at it is pressed in lite json
TBonnin
force-pushed
the
pcolley/facia_use_lite_fronts
branch
from
7faf937
to
841b605
Compare
TBonnin
force-pushed
the
pcolley/facia_use_lite_fronts
branch
from
6e137e7
to
5ab77b1
Compare
TBonnin
changed the base branch from
pcolley/facia_render_show_more_and_lite
to
master
This reverts commit ef9f7d8.
TBonnin
force-pushed
the
pcolley/facia_use_lite_fronts
branch
from
7d334bb
to
ea53427
Compare
| .toOption(storyCountTotal) | ||
| .getOrElse(Math.min(Configuration.facia.collectionCap, storyCountTotal)) | ||
| val storyCountVisible = Container.storiesCount(CollectionConfig.make(collection.collectionConfig), curated ++ backfill).getOrElse(storyCountMax) | ||
| val hasMore = storyCountVisible < storyCountMax |
There was a problem hiding this comment.
storyCountVisible should probably be min(storyCountVisible, storyCountMax) to avoid showing more than max
There was a problem hiding this comment.
storyCountVisible is either the number of stories necessary to fill the expected layout or storyCountMax.
In theory no container layout requires more than the max cap
prout-bot
added
Pending-on-PROD
Seen-on-PROD
and removed
Do not merge ⚠️
Pending-on-PROD
labels
|
Seen on PROD (created by @QuarpT and merged by @TBonnin 14 minutes and 56 seconds ago)
|
|
Time spent by Facia to read json Facia CPU I'll let you guess what time we deployed this change at. 😁 |
|
And the median response time for Facia (excluding the internal redirects) |
What does this change?
Use the lite fronts pressed by facia-press in Facia.
Can merge this to master after #18364 is merged
What is the value of this and can you measure success?
Facia can process smaller Json files for most requests, more performant - we be able to handle a higher request rate.
Tested in CODE?
I will