Improved supporter cta - no longer shows above header #18130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PRbuilds results: Screenshots 💚 Exceptions 💚 A11y validation Apache Benchmark Load Testing 💚 Microdata Validation --automated message |
gu-stav
approved these changes
Nov 2, 2017
|
@zeftilldeath Build should be green after a rebase 🥗 |
zeftilldeath
force-pushed
the
gone-full-circle
branch
from
f7cfd43 to
21eba57
Compare
|
Seen on PROD (merged by @zeftilldeath 28 minutes and 46 seconds ago)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The supporter call to action was peaking outside of the navigation.
Before
After
I've had to scoop up the circle as a separate span so I can mask just the top edge using overflow hidden. Now as you hover nothing is clipped as the circle expands.